T&C pop-up not popping up

[jxm28788]

On one of my sites the T&C popup on the first page of the checkout doesn't work. If you click on the link it just displays an "error on page" warning in the bottom left corner (in IE) - but no pop-up.

The offending code is -Click <A HREF="javascript:ShowPopUp('http://www.mydomain.co.uk/infopopup%2ehtml',650,450);">here</A> to view the Terms and Conditions

I have confirmed that:


The page referred to does actually exist, and
the code above is identical to the code on one of my other sites that does work as expected

So, firstly, any ideas what the problem might be, and secondly, where exactly is that code because I can't find it anywhere in any of the templates so I can't even replace it with a direct link.

[TraceyHand]

not editting out the domain name would have been helpful so someone could have taken a look.

[jxm28788]

www.dymo-label-printers.co.uk

[TraceyHand]

I'm wondering if the problem is due to the fact that you've removed the acatalog folder and it's confused Actinic?
Is the other site (the one that works) the same?

[jxm28788]

all of my sites are like that (I have a lot), and this is the only one with this problem.

[TraceyHand]

yeh..I can see that now
Firefox is giving some errors in the error console including Error: ShowPopUp is not defined
Source File: javascript:ShowPopUp('http://www.dymo-label-printers.co.uk/acatalog/infopopup%2ehtml',650,450);
Line: 1but, as you're using V7, I'm going to leave it to someone with more knowledge in V7 to see if that can advise how to resolve it

[jxm28788]

hmm... maybe something further up has been deleted... how do you access the error console in firefox just out of interest?

thanks.

[Mike Hughes]

Error: ShowPopUp is not defined
Source File: javascript:ShowPopUp('http://www.dymo-label-printers.co.uk/acatalog/infopopup%2ehtml',650,450);
Line: 1

If this is the reported error, then isn't the /acatalog/ bit going to cause a problem if you've removed that from the website.

Mike

[jxm28788]

ah, found the console - hey that's useful, and the page is full of errors...

But when I look at the error log it is not displaying the /acatalog part of the path. Are you definately seeing that?

But the error itself suggests that it is the showpopup that is the problem as it hasn't been defined - so where is that defined normally? Having looked at the (final) code of both pages they both have -

<script type="text/javascript" language="JavaScript" src="actiniccore.js"></script>
<script type="text/javascript" language="JavaScript" src="actinicextras.js"></script> so not sure where else it would be defined?

[TraceyHand]

hmm... maybe something further up has been deleted... how do you access the error console in firefox just out of interest?

thanks.

I'm not sure if it's bundled in with Firebug? (have never used FF without Firebug lol)
Above right of my browser window, I have 2 green ticks (not sure why 2, they're both the same!) if a page is error-free and red crosses, if there are errors on the page. Clicking on them lists the errors

[TraceyHand]

odd, I just C&Ped the error from the console :confused:

weird, just checked it again and no acatalog
how strange!
I didn't edit it in first time! LOL

[jxm28788]

hmm, that's odd I get the error without (see attachment). Don't think I'm using firebug thought, I just found the error console in the tools menu... But bizarre that they give different paths...???

[jxm28788]

If this is the reported error, then isn't the /acatalog/ bit going to cause a problem if you've removed that from the website.ok, so that leads me back to my other question, which was where the heck is it? If I could just find the code I could replace it with something hardcoded instead of relying on actinic to generate it.

[leehack]

If it is not in the template for that checkout page, then it must be a layout in the template manager, can only be one of those two areas surely. If your other sites work perfect, can you not wind the cogs back and recall what you did on those?

[jxm28788]

well you'd think so... but buggered if I can find it. It's not in the template for that page (Act_Order00.html), that just contains this variable which is hiding the code - NETQUOTEVAR:INFOPANELS.

I've also gone into explorer and searched on all act*.html files containing the word showpopup - and there are none...

I guess I'll have to experiment with the INFOPANELS variable - ie. take it out and see it it translates into that one line or is there a bunch of other code in there as well...

[leehack]

It wouldn't be order00 would it, it'd be order01 surely?

EDIT: Ignore me I am talking crap and thinking of the tick to confirm you've read the T&C's.

[Mike Hughes]

What can I say? If I look at the terms and conditions link I see this:

javascript:ShowPopUp('http://www.dymo-label-printers.co.uk/http://www.dymo-label-printers.co.uk/infopopup.html',650,450);

Very odd. I can only assume you're playing with it to see what happens.

Mike

[NormanRouxel]

In the source of your checkout page I see (at the top)

<actinic:basehref value="http://www.dymo-label-printers.co.uk/"></actinic:basehref>

Which I'd have expected the Perl scripts to have replaced with a

<base href="http://www.dymo-label-printers.co.uk/" />

As this isn't happening, the actinicore.js and actinicextras.js cannot be located (checkout pages come from your cgi-bin and these JavaScript files are not there).

No Ideas as to why this is happening though.

[NormanRouxel]

In V7 (I looked in a 7.0.4 site) templates the BASEHREF line is usually

<Actinic:BASEHREF VALUE="NETQUOTEVAR:BASEHREF"/>

You seem to have

<actinic:basehref value="NETQUOTEVAR:BASEHREF"></actinic:basehref>

The capitalisation of BASEHREF may be important.

Best check a Primary Template that hasn't been tinkered with.

[jxm28788]

yes, I was playing when you saw that double url. I have now replaced the INFOPANELS with a standard 'target=_blank' href and it works fine.

Yes the baseref does look different to the other site, I will have to investigate that further. Thanks.

[NormanRouxel]

I will have to investigate that furtherWorth doing as there will be other problems caused by this (like the Actinic JavaScripts not being loaded - so no cart summary). Browse your site using Firefox and use its Tools / Error Console to see.

[jxm28788]

yes, but my firefox is reporting that the attribute "heigth" is not recognised. But it is doing this on every website I visit... so not really sure how many of the errors are real and how many are just bugs in firefox...

[NormanRouxel]

but my firefox is reporting that the attribute "heigth" is not recognised
That's probably a warning. Warnings are less important.

It's errors with red crosses that you need to worry about.